OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo
Apache License 2.0
0 stars 1 forks source link

Signature widget images (and sometimes all fields) are not submitted successfully when entered via Android Chrome #42

Open Apotischman opened 1 year ago

Apotischman commented 1 year ago

Describe the bug A user will fill out a form that contains 2 signature widgets. When the data gets saved, one or both of the signatures fails to save correctly and the field looks blank. There have been times where all of the fields never save correctly, but the key is that the form has to have 2 signature widgets with saved signatures.

This originally came in via Anonymous form mode. In this scenario, I have reproduced it with a form that had 2 text fields and 2 signature fields. Sometimes the 2nd signature field would be blank; sometimes data from both text fields and both signatures are missing. We still believe the signature widgets are the cause.

To Reproduce We will be uploading more logs as soon as we can. Please see the attached files for reference. Both of the screenshots are from the same form, but the first screenshot has 2 files, whereas the second screenshot only has 1 file when we were expecting 2. The last screenshot shows side by side where there are 2 files and 1 file.

Screenshots

2 Files 1 File Screenshot 2023-03-15 at 3 22 10 PM

Browser and OS (please complete the following information):

Android Chrome Version 111.0.5563.57

Additional context Add any other context about the problem here.

MartijnR commented 1 year ago

The signature widget is undergoing a significant rewrite. I think the built-in delay (that has caused most issues in the past) is being removed. Since I will not be able to reproduce this anyway if it's Android&Chrome-specific, it might be best to see if the forthcoming release of Enketo Core resolves it.

You could also consider posting an issue in enketo/enketo-express but only if you can reproduce it with the official (non-forked) Enketo.

pbowen-oc commented 1 year ago

@MartijnR - Would additional server logs be helpful for you to see what is happening?

MartijnR commented 1 year ago

No, not really if this is OS/browser specific.

Enketo/enketo-express was just updated with the changed drawing widget. Best next step would be to test that even though it doesn't directly address this issue.

pbowen-oc commented 1 year ago

We are still seeing submission issues. Enketo is failing to complete submission on a form with multiple signature widgets. We'll provide more details soon.

pbowen-oc commented 1 year ago

Suggestion from Martijn - Try testing in ODK Cloud or Kobo Toolbox to see if we can reproduce it in standard Enketo.

pbowen-oc commented 1 year ago

We have more reports of failures in iOS and Android in our Prod environment (6.0.0.oc-7).

There are also reports of failures on a Mac laptop in our Dev environment (master branch).

We'll add the form definition for further testing.

pbowen-oc commented 5 months ago

This was temporarily fixed until we reverted the more recent signature widget changes. It has returned now that hose changes are reverted in our branch.

pbowen-oc commented 4 months ago

This issue was reported again for anonymous forms (i.e., form submission mode) for iOS 17.3.