OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo
Apache License 2.0
0 stars 1 forks source link

Print view formatting adds extra line breaks for select_one and select_multiple item labels #44

Open pbowen-oc opened 1 year ago

pbowen-oc commented 1 year ago

Steps:

  1. Open the attached form with span tags in the item labels - span labels.xform.txt
  2. Note that no line breaks are added between the span tags
  3. Click the Print icon

Expected: Print view matches the on-screen view with respect to line breaks in labels.

Actual: Print view inserts a line break between span tags in labels for select_one and select_multiple items.

On-screen view: Screenshot 2023-02-28 001922

Print view: Screenshot 2023-02-28 002008

MartijnR commented 1 year ago

Looks like a too-aggressive CSS role in the print css

enketo-core: http://localhost:8005/?xform=span.labels.xml

I'm seeing a possible issue in enketo-transformer that is causing this, but am not yet able to reproduce these extra linebreaks in the same Enketo installation.

Update, what I was seeing was a difference between a formatted XForm and an unformatted one. The above issue must be a CSS issue in Enketo Core after all.

pbowen-oc commented 8 months ago

@MartijnR - Is there any update on when this can be merged? Was it in a newer release already?

MartijnR commented 8 months ago

It was merged in Enketo Core in 7.1.0, and in Enketo Express in 6.1.0 (so not in your master yet).