search

OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo
Apache License 2.0
0 stars 1 forks source link

Fix/remove temp workaround for pages #5

Closed MartijnR closed 1 month ago

MartijnR commented 2 months ago

Closes # https://github.com/OpenClinica/enketo-oc/issues/26

This removes the temporary workaround because it is no longer required.

MartijnR commented 2 months ago

@gushil, I had to 'Edit', swap to another base, and then swap back to the 'main' base for this PR to update the diff. Now it is showing just the single commit. It's weird, I thought GitHub always updated automatically in the past. Maybe I'm misremembering because it is a little unusual to stack PRs on top of other PRs (in this case, it is better though imo).

gushil commented 1 month ago

@gushil, I had to 'Edit', swap to another base, and then swap back to the 'main' base for this PR to update the diff. Now it is showing just the single commit. It's weird, I thought GitHub always updated automatically in the past. Maybe I'm misremembering because it is a little unusual to stack PRs on top of other PRs (in this case, it is better though imo).

That is weird. Yes, now it looks 'right'.

Thanks!