Fieldsubmission feedback messages showing text from two different locales

[malcjackson]

Describe the bug Loading a form in the ja locale with a language query parameter of de, the form UI is showing some text in ja and some text from the de locale.

To Reproduce Create form that includes en and ja langauge settings (not de), and access the form with a language query parameter of DE and browser locale of JA: Language Query Parameter: DE Browser Locale: JA Expected form lang: JA Expected form UI lang: DE

Outcome: Some labels in the form UI appear in JA, some appear in DE. The form loads in JA as expected.

[MartijnR]

@malcjackson, could you please share the XForm? (considering I couldn't reproduce OpenClinica/enketo-oc#58)

[malcjackson]

multilanguagefom.txt Here's an example of a form we're seeing this in. When this form is accessed with a DE language query parameter, it's showing the up like this. The form in fr, and the UI in a mix of de/en.

[MartijnR]

There is an interesting issue with that form. It has an empty space (newline) before the <?xml declaration. I believe this makes the file invalid. Not sure if that's the issue here though. It seems unlikely that the form would load at all if that was the issue.

I see this in the single/fs/i view with a lang=de query parameter:

Could you email/post is the form URL (src of iframe element) please. You could remove the domain and the Enketo and ecid ID. I just would like to see the path and the lang query parameter.

[MartijnR]

Try review-only mode (see German above button), and readonly as well.

regular: http://localhost:8005/single/fs/i/9ZxLSiE7?ecid=a&lang=de readonly: http://localhost:8005/view/fs/i/de100510370cfdf124a22eb966f11d23?ecid=a&lang=de

review-only:

curl --user enketorules: -d "server_url=http://localhost:3000&form_id=multilang-nodefault&lang=de&instance=\
    <data><page1><locale_note/><yn1>1</yn1><yn1_comment/></page1><meta><instanceID>a</instanceID></meta></data>&instance_id=a&ecid=b" http://localhost:8005/oc/api/v1/instance/note

I cannot reproduce so far. I see French buttons etc, except for the "You're in review-only mode" because that translation is missing in French.

• [x] Try the OC branch with the added translations

Yes, I can reproduce it with the readonly view in the 4.0.1.oc branch (latest) only

The translation-combined.json built files look correct ("schreibgeschützten" is only present in the german files).

[MartijnR]

• [x] check if this is a new scenario that I did not test for - I did not but the next point is the equivalent which I think was tested for.
• [x] check if the same problem occurs with a browser set to de without lang parameter - yes, it looks like this is the same case. It seems to just use german as the backup language for missing strings. I am not sure if that is actually a bug.
• [x] does adding French translations for those german strings avoid the issue? - No!
• [x] Is it a browser caching issue with translation-combined.json? - No
• [x] reproduce in master by adding german translation-combined.json and french translation-combined.json
• [x] fix (probably something specific about how those 2 strings are added ) - yes, it's in the _convertToReadonly function which is called in enketo-webform-oc.js. This should be changed to add span elements with data-i18n tags so they switch to another language correctly.

[MartijnR]

• [x] also fix messages "all changes saved", "saving", "error saving" etc also not translated correctly

[MartijnR]

internal PR https://github.com/OpenClinica/enketo-express-oc/pull/623