Look into whether ecid can be influenced by another tab

[MartijnR]

For submitting a complete record (without any validation logic) for a form that has validation logic and would not accept an empty record as 'complete'.

Has nothing to do with offline-capable forms.

Manually changing the ecid would allow one to reproduce this, but the questions whether Enketo can get confused and use the wrong ecid.

[MartijnR]

0. ecid value is read on the client here: https://github.com/OpenClinica/enketo-express-oc/blob/master/public/js/src/module/settings.js#L45
1. ecid is added to fieldsubmission/complete URL here: https://github.com/OpenClinica/enketo-express-oc/blob/master/public/js/src/module/field-submission-queue.js#L18-L23
2. on the Enketo server it is handled here: https://github.com/OpenClinica/enketo-express-oc/blob/master/app/controllers/fieldsubmission-controller.js#L55-L61
3. which uses the complete function here: https://github.com/OpenClinica/enketo-express-oc/blob/master/app/controllers/fieldsubmission-controller.js#L74
4. which copies the ecid value here: https://github.com/OpenClinica/enketo-express-oc/blob/master/app/controllers/fieldsubmission-controller.js#L107

• [x] why is the server-side code still using PUT? Wasn't that changed to POST? --- The API was not changed, but it seems to not have been properly implemented and is in fact using POST already.

[MartijnR]

I have not been able to find a bug in Enketo that would allow ECID values to be incorrectly added to /fieldsubmission/complete calls. They seem to always be taken from the query parameter in the current Enketo form URL.

I have not looked into any possible interaction with offline-capable form URLs.