node-sass now dev dependency

OpenClinica / enketo-oc

OpenClinica's fork of the Enketo web forms monorepo

Apache License 2.0

0 stars 1 forks source link

node-sass now dev dependency #85

Open MartijnR opened 2 years ago

MartijnR commented 2 years ago

also grunt-sass

https://github.com/enketo/enketo-express/commit/0f338b063000b4ac8b02403923ca1a61d4247ea9

also esbuild and esbuild-plugin-alias

@svadla-oc, I found 4 modules that would be missing, so since you clear node_modules every time, you may also not get the latest javascript build. Created PR for enketo/enketo-express to fix.

MartijnR commented 2 years ago

https://github.com/enketo/enketo-express/pull/406/files

svadla-oc commented 2 years ago

Got it. Thanks @MartijnR

pbowen-oc commented 2 years ago

We are testing with the updated build commands now.

MartijnR commented 2 years ago

I think those updated build commands will be the "new way". So npm install && npm prune production. Alternatively we could at this point explore publishing the built files in the repo so you wouldn't have to build yourself anymore. This might work for OpenClinica if:

always the same widgets are enabled in all Enketo installations that OC has
OC always uses the same "base path" config item value

(There may be something else that I'm overlooking)