search

OpenCodeEra / ML-X

Dive into a rich assortment of machine learning models, perfect for learners and experts alike.
MIT License
5 stars 12 forks source link

Added netflix data visualization #13

Closed Chandak-Keshav closed 1 year ago

Chandak-Keshav commented 1 year ago

I have added various visualizations to the two datasets "titles.csv" and credits.csv" to understand the data and it's attributes like genres, imdb ratings, and distribution of roles(actors/directors).

AKACHI-4 commented 1 year ago

I have added various visualizations to the two datasets "titles.csv" and credits.csv" to understand the data and it's attributes like genres, imdb ratings, and distribution of roles(actors/directors).

@Chandak-Keshav, you don't need to commit the dataset here.

however, please ensure that you add the link to the dataset you are using in your notebook. also, include more details in the notebook so that others can understand it better.

Chandak-Keshav commented 1 year ago

I have done the required changes. Kindly consider my PR request @AKACHI-4

Chandak-Keshav commented 1 year ago

I have added the spaceship titanic visualization as well @AKACHI-4 . Kindly consider my PR Thanks

AKACHI-4 commented 1 year ago

Your PR looks fine, @Chandak-Keshav. I will happily merge it, but will it be okay with you if both issues are considered in one PR?

AKACHI-4 commented 1 year ago

@Chandak-Keshav change the name of notebook .. it is notebook.ipnyb

Chandak-Keshav commented 1 year ago

Your PR looks fine, @Chandak-Keshav. I will happily merge it, but will it be okay with you if both issues are considered in one PR?

If there is a way that 2 PRs can be considered, then it will be better. But, if it's not possible, then no issues. Also, I have changed the names of the files

AKACHI-4 commented 1 year ago

yah okay then... Just one last change as in current repo there is already a folder named Titanic Data Visualization so move your titanic dv notebook there and remove last one..

Chandak-Keshav commented 1 year ago

yah okay then... Just one last change as in current repo there is already a folder named Titanic Data Visualization so move your titanic dv notebook there and remove last one..

Done

AKACHI-4 commented 1 year ago

Great work, @Chandak-Keshav !

Congratulations 🎉, your pull request has been successfully merged!

If you find this repository helpful, please consider giving us a star by clicking ⭐.

And don't forget to share your achievement with your friends! 🚀

Chandak-Keshav commented 1 year ago

Also, we are tracking whether our repo is working fine for Hacktoberfest '23. So, when your PR is completely accepted on your Hacktoberfest profile, don't forget to let us know. You can also share the PR badge on your socials and send us the post link.

Thank you @AKACHI-4 . Will surely let you know once it's accepted

AKACHI-4 commented 1 year ago

Also, we are tracking whether our repo is working fine for Hacktoberfest '23. So, when your PR is completely accepted on your Hacktoberfest profile, don't forget to let us know. You can also share the PR badge on your socials and send us the post link.

Thank you @AKACHI-4 . Will surely let you know once it's accepted

Yeah, sure, I will open a space in discussions so you can share it there..