OpenCodeFoundation / PlanCards

MIT License
2 stars 1 forks source link

What is the policy to update code on existing pull request? #12

Closed mahedee closed 1 week ago

mahedee commented 2 weeks ago

Say, I have created a PR. Some how code is not in up to the mark. In this case, what should I do? Do I need to create new issue? Or, just update the code, commit on the existing branch? I mean, what is the best practice?

ratanparai commented 2 weeks ago

You should update the initial pull request branch by commiting new changes as requested by the reviewer.

One feature branch may and should have multiple commits. It is good practice to commit frequently too.

mahedee commented 1 week ago

@ratanparai , got it thanks.

ratanparai commented 1 week ago

@mahedee You are welcome bhai