Closed malakar-swastik closed 3 years ago
Hi @malakar-swastik I would request some changes
Okay sure.
On Thu, Oct 1, 2020, 13:46 Anushka Shukla notifications@github.com wrote:
Hi @malakar-swastik https://github.com/malakar-swastik I would request some changes
- Kindly remove the readme file from the UI Design Drafts folder as we already have one and we do not need that when it will be merged. for anything to ask or state do comment in the thread itself.
- Rename the names of the ".png" files to more specific one like "LOGIN.png" or "HOME.png".
- Kindly resize the images if possible.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neil-dev/YouSafe/pull/10#issuecomment-701971688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3BF4YY6R2DPERVA6Q3IMLSIQ3HHANCNFSM4SABOC2Q .
@malakar-swastik keep the authentication and login files and remove the rest as they are in conflict with the vision of our app. Also, can you add just the logo separately?
Okay sure.
On Fri, Oct 2, 2020, 10:11 Neil notifications@github.com wrote:
@malakar-swastik https://github.com/malakar-swastik keep the authentication and login files and remove the rest as they are in conflict with the vision of our app. Also, can you add just the logo separately?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neil-dev/YouSafe/pull/10#issuecomment-702521683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3BF46IFXME5P627AKEZBTSIVKYNANCNFSM4SABOC2Q .
@malakar-swastik I have merged your PR, however, a small change has to be made. In login.png, remove "Create Account? Sign up" line and change "login button" to "Signin". In the authentication.png file add a "Verify" button below the text field. Also change the text field to six separate boxes, each for one OTP digit. Make these changes and create a new PR.
Cool. Will do.
On Fri, Oct 2, 2020, 18:44 Neil notifications@github.com wrote:
@malakar-swastik https://github.com/malakar-swastik I have merged your PR, however, a small change has to be made. In login.png, remove "Create Account? Sign up" line and change "login button" to "Signin". In the authentication.png file add a "Verify" button below the text field. Also change the text field to six separate boxes, each for one OTP digit. Make these changes and create a new PR.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neil-dev/YouSafe/pull/10#issuecomment-702727101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3BF4ZHEKCXWQ467R7YT3TSIXG4JANCNFSM4SABOC2Q .
Added the UI Design for App. However, since no logo was available, I have used a default placeholder .