search

OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 2 forks source link

CIEL v2022-05-21 release #1308

Closed bmamlin closed 2 years ago

bmamlin commented 2 years ago

Staging

Production

bmamlin commented 2 years ago

When validating CIEL v2022-05-21 on Staging, there were 314 mappings to retire. After those were retired, validation showed 23 cases where OCL had multiple copies of mappings. All of these mappings contain %2F in the code, so this might reflect a bug in OCL when updating mappings containing a forward slash in the code. I will clean these up manually.

There was also an error from a duplicate mapping in CIEL v2022-05-21, where there's a duplicate mapping entry where Glucose, serum 1.5 hrs post 75g oral glucose (mg/dL) is mapped as SAME-AS PIH:14228. I'll let Andy know about this so he can remove it from future releases of CIEL.

bmamlin commented 2 years ago

The strange thing with these duplicate mappings created during the import is that neither duplicate appears to be created by the current import. For example, for the first concept with duplicate mappings (165965), here are the timestamps for the duplicate mappings on Staging:

{
  "url": "/orgs/CIEL/sources/CIEL/mappings/1511058/",
  "created_on": "2021-06-10T10:15:15.083029Z",
  "updated_on": "2022-05-25T06:39:09.697329Z",
}
{
  "url": "/orgs/CIEL/sources/CIEL/mappings/1170682/",
  "created_on": "2021-03-31T11:34:30.154808Z",
  "updated_on": "2021-12-16T15:39:10.934550Z",
}

I'm assuming the older mapping is the "correct" one and the one with an updated_on of 2022-05-25` the "duplicate". I've included the full JSON below in case it's useful to @snyaggarwal for investigation.

Looking at these mappings as I retired them, it looks like this isn't the first time they been "unretired". For example, looking at this history of /CIEL/mappings/1511054/, it looks like I've retired it as a duplicate following previous imports of CIEL.

Full JSON... ```json { "external_id": "286100ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB", "retired": false, "map_type": "NARROWER-THAN", "source": "CIEL", "owner": "CIEL", "owner_type": "Organization", "from_concept_code": "165965", "from_concept_name": null, "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/165965/", "to_concept_code": "RA01.1/1D84.Y", "to_concept_name": null, "to_concept_url": null, "from_source_owner": "CIEL", "from_source_owner_type": "Organization", "from_source_url": "/orgs/CIEL/sources/CIEL/", "from_source_name": "CIEL", "to_source_owner": "WHO", "to_source_owner_type": "Organization", "to_source_url": "/orgs/WHO/sources/ICD-11-WHO/", "to_source_name": "ICD-11-WHO", "url": "/orgs/CIEL/sources/CIEL/mappings/1511058/", "version": "1511058", "id": "1511058", "versioned_object_id": 1511058, "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/1511058/", "is_latest_version": false, "update_comment": null, "version_url": "/orgs/CIEL/sources/CIEL/mappings/1511058/6768051/", "uuid": "1511058", "version_created_on": "2021-06-10T10:15:15.083029Z", "from_source_version": null, "to_source_version": null, "from_concept_name_resolved": "Conjunctivitis due to disease caused by Severe acute respiratory syndrome coronavirus 2 (SARS-CoV-2)", "extras": {}, "type": "Mapping", "created_on": "2021-06-10T10:15:15.083029Z", "updated_on": "2022-05-25T06:39:09.697329Z", "created_by": "ocladmin", "updated_by": "ocladmin", "public_can_view": true } ``` ```json { "external_id": "286100ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB", "retired": false, "map_type": "NARROWER-THAN", "source": "CIEL", "owner": "CIEL", "owner_type": "Organization", "from_concept_code": "165965", "from_concept_name": null, "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/165965/", "to_concept_code": "RA01.1/1D84.Y", "to_concept_name": null, "to_concept_url": null, "from_source_owner": "CIEL", "from_source_owner_type": "Organization", "from_source_url": "/orgs/CIEL/sources/CIEL/", "from_source_name": "CIEL", "to_source_owner": "WHO", "to_source_owner_type": "Organization", "to_source_url": "/orgs/WHO/sources/ICD-11-WHO/", "to_source_name": "ICD-11-WHO", "url": "/orgs/CIEL/sources/CIEL/mappings/1170682/", "version": "1170682", "id": "1170682", "versioned_object_id": 1170682, "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/1170682/", "is_latest_version": false, "update_comment": null, "version_url": "/orgs/CIEL/sources/CIEL/mappings/1170682/5830089/", "uuid": "1170682", "version_created_on": "2021-03-31T11:34:30.154808Z", "from_source_version": null, "to_source_version": null, "from_concept_name_resolved": "Conjunctivitis due to disease caused by Severe acute respiratory syndrome coronavirus 2 (SARS-CoV-2)", "extras": {}, "type": "Mapping", "created_on": "2021-03-31T11:34:30.154808Z", "updated_on": "2021-12-16T15:39:10.934550Z", "created_by": "ocladmin", "updated_by": "ocladmin", "public_can_view": true } ```
bmamlin commented 2 years ago

1309 created for the duplicate mappings following bulk import bug.

bmamlin commented 2 years ago

CIEL v2022-05-21 released on Staging and Production