OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 2 forks source link

Repo Header showing unnecessary information #1355

Open jamlung-ri opened 2 years ago

jamlung-ri commented 2 years ago

We should be clear about what fields should be shown in the header of OCL repositories. Currently, if I fill in FHIR fields, they are appearing in the header. See image below for this source.

I propose that the header should not show any information that is in the Advanced Settings section of the form. Meaning, the following fields are fair game to show if filled in:

image.png

paynejd commented 2 years ago

Agree with Joe about hiding these from the header, but we need to decide where all of these hidden fields will be visible in the UI. We used to have a tab dedicated to the repository details, but it turned out to be mostly duplicative of the header. Now that we've added more fields, we need to design a new place for advanced fields to live.

On Fri, Sep 23, 2022 at 1:20 PM Joseph Amlung @.***> wrote:

Assigned #1355 https://github.com/OpenConceptLab/ocl_issues/issues/1355 to @paynejd https://github.com/paynejd.

— Reply to this email directly, view it on GitHub https://github.com/OpenConceptLab/ocl_issues/issues/1355#event-7449063820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCOOKS7FWVQ2RQWJ44PZTV7XRGNANCNFSM6AAAAAAQUFH5KI . You are receiving this because you were assigned.Message ID: @.***>

snyaggarwal commented 2 years ago

@paynejd @jamlung-ri Just to add more context to this. When we did customization of Source/Collection headers via configurations, we added some inbuilt logic.

  1. Default list of visible attributes -- source/collection_type, default/supported_locales, custom_validation_schema, and canonical_url -- these will always be visible on top if they have value.
  2. other attributes -- Everything else that has value. These will be visible in the header if they are less than 4, otherwise, they are collapsed with the "more" option to expand.