search

OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 2 forks source link

CIEL v2022-12-21 release #1447

Closed bmamlin closed 1 year ago

bmamlin commented 1 year ago

Staging

Production

bmamlin commented 1 year ago

@snyaggarwal,

An exception occurred while importing concepts on production: 😕

TASK 6b96a7c8-7fa6-4dd6-a11c-6db511caa0d4-ocladmin~priority deadlock detected DETAIL: Process 30993 waits for ShareLock on transaction 22361343; blocked by process 1882. Process 1882 waits for ShareLock on transaction 22361339; blocked by process 30993. HINT: See server log for query details. CONTEXT: while updating tuple (5131,10) in relation "concepts"

bmamlin commented 1 year ago

The following 69 concepts ended up with duplicate mappings on production:

snyaggarwal commented 1 year ago

@bmamlin These were retired and HEAD export was retriggered.

bmamlin commented 1 year ago

Thanks @snyaggarwal.

On Staging, 12 concepts ended up with duplicate mappings following import of CIEL v2022-12-21:

These 11 have duplicate NARROWER-THAN mappings:

This concept has a duplicate SAME-AS mapping:

Any idea why these are cropping up? Am I doing something wrong? Let me know if/when you want me to retire the duplicates of these mappings. Once they're deleted, I'll need to generate a new export of HEAD for validation.

bmamlin commented 1 year ago

@snyaggarwal,

I still see four duplicate mappings for HEAD on prod:

Are these regenerating? Or do you think you might've missed 4 of 69? 😄 I'm happy to retire these and regenerate an export of HEAD, but want you to know in case it helps you troubleshoot & squash bugs. Let me know when I can retire them & regenerate an export of HEAD.

snyaggarwal commented 1 year ago

@snyaggarwal,

I still see four duplicate mappings for HEAD on prod:

  • 160036 - /orgs/OpenMRS/sources/org.openmrs.module.mdrtb/concepts/PATIENT+TRANSFERRED+OUT/
  • 159635 - /orgs/OpenMRS/sources/org.openmrs.module.mdrtb/concepts/TELEPHONE+NUMBER/
  • 159395 - /orgs/OpenMRS/sources/org.openmrs.module.mdrtb/concepts/CLINICIAN+NOTES/
  • 159346 - /orgs/OpenMRS/sources/org.openmrs.module.mdrtb/concepts/EXTENSIVE+DRUG+RESISTANT+TUBERCULOSIS/

Are these regenerating? Or do you think you might've missed 4 of 69? 😄 I'm happy to retire these and regenerate an export of HEAD, but want you to know in case it helps you troubleshoot & squash bugs. Let me know when I can retire them & regenerate an export of HEAD.

@bmamlin I missed these 4. Retired now and regenerating HEAD.

snyaggarwal commented 1 year ago

Thanks @snyaggarwal.

On Staging, 12 concepts ended up with duplicate mappings following import of CIEL v2022-12-21:

These 11 have duplicate NARROWER-THAN mappings:

  • 165897 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FJB63.Y/
  • 165887 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FCA20.Z/
  • 165886 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FAB0Z/
  • 165885 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2F1A2Z/
  • 165884 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2F8E47/
  • 165883 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FBC42.Y/
  • 165869 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FCA42.Y/
  • 165868 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FCA4Z/
  • 165867 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FCB00/
  • 165866 - /orgs/WHO/sources/ICD-11-WHO/concepts/QC42%2FRA01.1/
  • 165608 - /orgs/WHO/sources/ICD-11-WHO/concepts/RA01.1%2FCA40.1Y/

This concept has a duplicate SAME-AS mapping:

  • 160009 - /orgs/OpenMRS/sources/org.openmrs.module.mdrtb/concepts/DIRECT%2FINDIRECT/

Any idea why these are cropping up? Am I doing something wrong? Let me know if/when you want me to retire the duplicates of these mappings. Once they're deleted, I'll need to generate a new export of HEAD for validation.

@bmamlin I retired these 12 mappings and triggered the HEAD export. I don't think you are doing anything wrong, it's the data these env have. The duplicates are coming with each import because some of the old version data is not correct, I thought I fixed that, but clearly not! I am looking into this.

snyaggarwal commented 1 year ago

@bmamlin I have deployed the fix on Staging and reimported one of the duplicate mappings, and it worked fine (no duplicates). Will trigger HEAD export now

bmamlin commented 1 year ago

Thanks @snyaggarwal. I've validated & released CIEL v2022-12-21 on staging & production (I deleted the version @askanter released on production and recreated it, since the version he released hadn't been validated and had duplicate mappings in it).