OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 1 forks source link

Repository version summary #1478

Open paynejd opened 1 year ago

paynejd commented 1 year ago

@snyaggarwal after you finish the final tweaks that we discussed today... @paulsonder would you be willing to take a look and provide some quick design advice for this new feature?

https://app.qa.openconceptlab.org/#/orgs/CIEL/sources/CIEL/summary

image.png

paulsonder commented 1 year ago

@paynejd Is there an original brief / set of requirements I can read before feeding back?

paynejd commented 1 year ago

Hi @paulsonder - here is the original ticket with a few details: #1467

We did this one a bit scrappy, so there's plenty of room to rethink this one

paulsonder commented 1 year ago

Hi @snyaggarwal

My apologies for just getting around to this.

This seems OK to me, particularly to gather feedback from users on how useful it is and how we organise the content.

It's not super clear from the original ticket what the problem framing was originally when the feature was proposed, or who is the audience is, so from a content point of view I can't really offer feedback right now.

Two small feedback points on the UI:

  1. In the CIEL example, the retired concepts in the indicator bar appear to be in red but as shown first, those the label below refers to 'Active' Concepts... I would expect the bar to be flipped, showing Active out of a Total number.

  2. The Mapped to and from controls don't appear clickable... could they sit inside an accordion so there's an obvious interaction?

I'll make sure to collect some users feedback on this before reworking it as part of the DS / redesign project.

snyaggarwal commented 1 year ago

@paulsonder thanks for the quick feedbacks, I have added both. Did you notice the use of Skeleton vs Loader? What do you think about that?

paulsonder commented 1 year ago

Skeleton all the way...

On Wed, 22 Mar 2023 at 12:59, Sny @.***> wrote:

@paulsonder https://github.com/paulsonder thanks for the quick feedbacks, I have added both. Did you notice the use of Skeleton https://mui.com/material-ui/react-skeleton/ vs Loader https://mui.com/material-ui/react-progress/#circular-color? What do you think about that?

— Reply to this email directly, view it on GitHub https://github.com/OpenConceptLab/ocl_issues/issues/1478#issuecomment-1479425484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWYND7VDDTG7U26DJJCOBU3W5LSSRANCNFSM6AAAAAAUX5RFT4 . You are receiving this because you were mentioned.Message ID: @.***>

jamlung-ri commented 1 year ago

@snyaggarwal A bug with this - I am seeing the Summary tab displaying the table awkwardly before the MapType rows are expanded. Attaching some screenshots taken of Production

Example screenshot before expansion: image

Example screenshot after rows are expanded: image

snyaggarwal commented 1 year ago

@jamlung-ri Yes! That's my bad UX skills :) I will explain the reason for the way the interactions are in detail, it's mostly the performance of information extraction. We need to talk about this in our dev call and come up with better interaction and UI. Adding it to the agenda for next week.

paynejd commented 7 months ago

@paulsonder Flagging this for you for v3 -- @snyaggarwal implemented this in v2, but we didn't put a lot of effort into the design yet.

jamlung-ri commented 6 months ago

One idea here: for repos that contain a mix of content (i.e. collections), you should be able to see which repo versions (i.e. sources and other collections) are being pulled from to make this collection.

jamlung-ri commented 3 weeks ago

User Story: Summarize the contents of a specific repo

Acceptance criteria:

Note: Repo type-specific summaries need to be designed