search

OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 1 forks source link

Please Delete the fake OpenMRS Org #1678

Open gracepotma opened 10 months ago

gracepotma commented 10 months ago

Dear OCL Team, Currently if someone searches for "OpenMRS" in OCL, two orgs come up:

image

The first one with the capital O created on 03/28/2021 by ocladmin should be deleted or archived so folks aren't distracted away from our main / "real" one :)

This keeps happening to me in live demos :P

Thanks so much <3

jamlung-ri commented 10 months ago

@paynejd @bmamlin This org appears to be entirely stagnant and should be easy enough to delete. Any concerns if I go ahead and do that? Including a screenshot below for the only content in that org, which is two empty sources.

image

paynejd commented 10 months ago

This is used as an external map source by CIEL. We'll need to migrate some data, but should be possible. Let's queue this up for discussion.

On Tue, Oct 24, 2023 at 8:09 AM Joseph Amlung @.***> wrote:

@paynejd https://github.com/paynejd @bmamlin https://github.com/bmamlin This org appears to be entirely stagnant and should be easy enough to delete. Any concerns if I go ahead and do that? Including a screenshot below for the only content in that org, which is two empty sources.

[image: image] https://user-images.githubusercontent.com/55999682/277652549-01ec4216-58d2-4fe2-bddd-cf988e580518.png

— Reply to this email directly, view it on GitHub https://github.com/OpenConceptLab/ocl_issues/issues/1678#issuecomment-1777083886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCOOKMUGSMOTRIARY2UTDYA6VYXAVCNFSM6AAAAAA6MWOV6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGA4DGOBYGY . You are receiving this because you were mentioned.Message ID: @.***>

paynejd commented 10 months ago

There are two sources in the older OpenMRS org:

@rkorytkowski is going to query the OCL production environment to see if these are being rferenced or mapped to anywhere else and then we'll decide how to approach it

jamlung-ri commented 9 months ago

Note that there are other orgs in OCL Online that may conflict in ID if you ignore casing: CORE + Core, MOH + MoH, MyOrg + MYORG, OpenMRS + openmrs, TEST + Test + test, testOrg + TestOrg, UGANDAEMR + UgandaEMR

bmamlin commented 9 months ago

There are two sources in the older OpenMRS org:

  • org.openmrs.module.mdrtb
  • org.openmrs.module.emrapi

This are examples of module-specific concepts – i.e., a "best practice" for OpenMRS module to use concepts is to specify their own mappings, so an implementation need only map their concepts to the ones needed by the module. In these cases, the module defines it's own source for mappings (like the 2 above). That said, if we've relaxed the requirement that sources must be defined to create a mapping, then we don't have to have these sources.

FWIW, I think this issue points to a bigger issue for OCL – i.e., URLs may be case-preserving; however, should not be case-sensitive. In other words, using a URL containing .../orgs/OpenMRS/... should be interchangeable with .../orgs/openmrs/... (OCL would always redirect or return URLs with the correct capitalization), but you shouldn't be able to create an org at /orgs/FooBar/ if /orgs/foobar/ already exists.