OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 1 forks source link

FHIR ConceptMap fails to import due to "null" map_type #1836

Open jamlung-ri opened 4 months ago

jamlung-ri commented 4 months ago

Many of the ConceptMap resources like this one are using equivalence to designate map type, while OCL is using relationship. OCL rejects the ConceptMap because it isn't finding a map_type field.

I also tried this on a ConceptMap that uses "relationship" for its map type, and it does import properly.

Example error:

('{"map_type":["This field may not be null."]}')
jamlung-ri commented 4 months ago

Quick update: I did a test load of FHIR ConceptMap resources in JSON format where I simply replaced the string "equivalence" with "relationship", and OCL successfully loaded the resources. This might support the idea of doing a quick fix where OCL simply recognizes either of those strings for the ConceptMap's map type.

rkorytkowski commented 4 months ago

The field should be 'equivalence' in v4. It was renamed in v5 to relationship, which I mistakenly introduced.

jamlung-ri commented 4 months ago

This has been working for me in recent tests. I think we can deploy this further when ready.