[Checksums] Test Import (using CIEL) with duplicate resources

snyaggarwal commented 1 month ago

This ticket is a followup on #1746.

Goal is to test duplicate resources should not get created from import using checksums.

Tasks:

[x] Regenerate concept/mapping checksums for HEAD CIEL version on QA
[x] Import last CIEL version on QA and check number of updates, should be 0
[x] Run a new CIEL version on QA and check number of updates, should match against changelog

snyaggarwal commented 1 month ago

Test 1: Same content upload should not create any new/duplicate resource versions - PASS

Import v2023-07-12 again and should not create any new concepts/mappings versions.

Result:

Import Summary: Started: 2024-05-29 03:20:23.981880 | Processed: 56162/56162 | Created: 0 | Updated: 0 | Deleted: 0 | Existing: 0 | Permission Denied: 0 | Unchanged: 56162

Test 2.a: New content upload should not create any changed resource versions only and should tally up with $compare results - PASS

Import v2023-09-11 should create few concepts/mappings versions and skip unchanged. This should match with $compare results

Result:

Concept Import Summary: Started: 2024-05-29 05:12:07.029457 | Processed: 56320/56320 | Created: 158 | Updated: 95 | Deleted: 0 | Existing: 0 | Permission Denied: 0 | Unchanged: 56067
Mapping Import Summary: Started: 2024-05-29 07:40:49.094572 | Processed: 228092/228092 | Created: 655 | Updated: 9838 | Deleted: 0 | Existing: 0 | Permission Denied: 0 | Unchanged: 217599

$compare: Results Matches with above

{
"version1": {
"uri": "/orgs/CIEL/sources/CIEL/v2023-07-12/",
"concepts": 54141,
"mappings": 227958
},
"version2": {
"uri": "/orgs/CIEL/sources/CIEL/v2023-09-11/",
"concepts": 54298,
"mappings": 228613
},
"diff": {
"concepts": {
  "new": 158,
  "removed": 0,
  "changed_total": 95,
  "changed_retired": 1,
  "changed_major": 51,
  "changed_minor": 43
},
"mappings": {
  "new": 655,
  "removed": 0,
  "changed_total": 26,
  "changed_retired": 0,
  "changed_major": 0,
  "changed_minor": 26
}
}
}

Full $changelog results are below: ciel_v2023-09-11_v2023-07-12.changelog.json

Test 2.b: $compare results should match with duplicate resources and without. - PASS

Staging has v2023-09-11 and v2023-07-12 generated with duplicate resources while QA without duplicate. $compare results should match:

Results from $compare in Staging --

{
    "version1": {
      "uri": "/orgs/CIEL/sources/CIEL/v2023-09-11/",
      "concepts": 54298,
      "mappings": 228092
    },
    "version2": {
      "uri": "/orgs/CIEL/sources/CIEL/v2023-07-12/",
      "concepts": 54141,
      "mappings": 227463
    },
    "diff": {
      "concepts": {
        "new": 158,
        "removed": 0,
        "changed_total": 95,
        "changed_retired": 1,
        "changed_major": 51,
        "changed_minor": 43
      },
      "mappings": {
        "new": 655,
        "removed": 0,
        "changed_total": 52,
        "changed_retired": 26,
        "changed_major": 0,
        "changed_minor": 26
      }
    }
  }

full $changelog - https://json.link/8tCtP4hmNd.json

bmamlin commented 1 month ago

FWIW, here's the diff my script created for CIEL v2023-09-11. Changes appear to match your findings (noting that I'm inferring and manually retiring mappings before bulk imports, so without that step QA is going to have some extra mappings compared to the actual content).

OpenConceptLab / ocl_issues