Whenever I try to add references to a Collection using an implicit criterium, the references are unresolved

[italomacedo]

Issue tracker is ONLY used for reporting bugs. New features should be discussed with us on OCL Chat or on one our slack channels.

We are maintaining some collections that have over 10.000 concepts. So, We've tried to add references to these collections using wildcards.

We have added the following reference to a Collection: {"expression":"/orgs/LOINC/sources/loinc/concepts/?extras.SCALE_TYPE=Doc*&verbose=true","reference_type":"concepts","id":189608,"last_resolved_at":null,"uri":"/orgs/HL7/collections/doc-typecodes/references/189608/","uuid":"189608","include":true,"type":"CollectionReference","code":null,"resource_version":null,"namespace":null,"system":null,"version":null,"valueset":null,"cascade":"","filter":null,"display":null,"created_at":"2024-06-12T19:03:14.040453Z","updated_at":"2024-06-12T19:03:14.040468Z","concepts":0,"mappings":0,"translation":"Include latest concepts","transform":null}

Expected Behavior

We'd expect that OCL would add the 10.000 concepts from LOINC 2.74 to that given Collection.

Current Behavior

OCL is adding just one reference (unresolved).

Possible Solution

If OCL could do wildcard addition considering Concept EXTRAS would be great.

Steps to Reproduce

1. I created the following Reference https://oclapi2.ips.hsl.org.br/orgs/HL7/collections/doc-typecodes/references/189608/
2. OCL processed it
3. Reference is shown as (unresolved)

Context (Environment)

We can't expand ValueSets using wildcard, and EXTRAS of the concepts. If we don't do that, We'd have to manually load these collections.

Detailed Description

IF we could process references using wildcards and EXTRAS, we'd be able to produce implicit expansions using the concepts properties.

Possible Implementation

Enable the possibility to add references to a collection using wildcard and EXTRAS in order to enable implicit expansion through the user interface.

[italomacedo]

@snyaggarwal Please help, and save our souls! <3

[snyaggarwal]

@italomacedo Thanks for creating such a descriptive ticket, it was super easy to understand.

A couple of issues here --

• [x] [Bug] Collection reference is getting unresolved for a valid expression
• [x] [New Feature] Reference filters to support extras.

I will work on this and update.

[snyaggarwal]

@italomacedo This is deployed on our QA and Staging servers. You can try this out.

[paynejd]

The implementation of extras being available for reference queries should be in alignment with FHIR code system properties. Let’s review our approach and probably create a follow up ticket specifically for properties.

On Fri, Jun 14, 2024 at 7:07 AM Sunny Aggarwal @.***> wrote:

@italomacedo https://github.com/italomacedo This is deployed on our QA and Staging servers. You can try this out.

— Reply to this email directly, view it on GitHub https://github.com/OpenConceptLab/ocl_issues/issues/1850#issuecomment-2167792572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCOOJ3ULDKSTZRKGRNTYTZHLFHPAVCNFSM6AAAAABJG6RQ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXG44TENJXGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[italomacedo]

I updated my instance and it works like a charm! Thanks Sunny!

[snyaggarwal]

The implementation of extras being available for reference queries should be in alignment with FHIR code system properties. Let’s review our approach and probably create a follow up ticket specifically for properties. … On Fri, Jun 14, 2024 at 7:07 AM Sunny Aggarwal @.> wrote: @italomacedo https://github.com/italomacedo This is deployed on our QA and Staging servers. You can try this out. — Reply to this email directly, view it on GitHub <#1850 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCOOJ3ULDKSTZRKGRNTYTZHLFHPAVCNFSM6AAAAABJG6RQ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXG44TENJXGI . You are receiving this because you are subscribed to this thread.Message ID: @.>

@paynejd This is using search criteria in reference filter definition. Since we lifted the restriction of reference filter definition in favor of FHIR, it felt like a good place to support extras. I have added this in our dev call tomorrow for discussion. This is deployed everywhere, closing this ticket.