search

OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 2 forks source link

v3 Search does not return private content #1887

Open jamlung-ri opened 4 months ago

jamlung-ri commented 4 months ago

When I search for a private source on QA from the v3 search, it doesn't appear. I can access the source directly from the organization, but the repo doesn't appear in global search.

Note that you can only tell the source is private from the v2 TermBrowser: https://app.qa.openconceptlab.org/#/orgs/private-org/sources/private-source/ @paulsonder Should this privacy status appear in the Repository designs? e.g. https://zpl.io/eznn8ql - I assume yes, unless we are waiting for the Permissions Framework.

@snyaggarwal Is this an intentional decision or a bug?

Private source search result failure

snyaggarwal commented 4 months ago

Hey @jamlung-ri I can see the repo in Global Search results And also in Org search results

jamlung-ri commented 4 months ago

Hmm, it seems to be showing up when logged in as OCLadmin, but not when I'm logged in as jamlung. Any ideas as to why that might be? I can find the source in v2 TermBrowser when logged in as jamlung.

image image

snyaggarwal commented 4 months ago

I tried to reproduce this with same user on TBv3 and TBv2 and got the same results. Not sure how is this happening for you. API is same for TBv2 and TBv3.

paulsonder commented 4 months ago

When I search for a private source on QA from the v3 search, it doesn't appear. I can access the source directly from the organization, but the repo doesn't appear in global search.

Note that you can only tell the source is private from the v2 TermBrowser: https://app.qa.openconceptlab.org/#/orgs/private-org/sources/private-source/ @paulsonder Should this privacy status appear in the Repository designs? e.g. https://zpl.io/eznn8ql - I assume yes, unless we are waiting for the Permissions Framework.

@snyaggarwal Is this an intentional decision or a bug?

Private source search result failure Private source search result failure

Hi @jamlung-ri - this design here does indicate whether the Repository is Public or Private in the Chip at in the Repo header. Does that answer the question?

jamlung-ri commented 4 months ago

I tried to reproduce this with same user on TBv3 and TBv2 and got the same results. Not sure how is this happening for you. API is same for TBv2 and TBv3.

Hmm, might be user error and/or browser issues. @paynejd or @paulsonder I added you both as a member to https://app.qa.openconceptlab.org/#/orgs/private-org/. Would you mind logging in as "jon" or "paulsonder" on V3 QA and testing this search query to see if you see "private-source" in global search? https://app.v3.qa.openconceptlab.org/#/search/?q=private&type=repos

paulsonder commented 4 months ago

Hi @jamlung-ri - I don't get any results when logged in as 'paulsonder'

paynejd commented 4 months ago

Also no results...

On Wed, Jul 17, 2024 at 11:26 AM Paul Adams @.***> wrote:

Hi @jamlung-ri https://github.com/jamlung-ri - I don't get any results when logged in as 'paulsonder'

— Reply to this email directly, view it on GitHub https://github.com/OpenConceptLab/ocl_issues/issues/1887#issuecomment-2233594511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJCOOJB2YSYJVDTHCHE64TZM2ELHAVCNFSM6AAAAABK5D6FWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGU4TINJRGE . You are receiving this because you were mentioned.Message ID: @.***>

snyaggarwal commented 3 months ago

@jamlung-ri I checked the behaviour from v2 and v3, found it to be the same.

jamlung-ri commented 3 months ago

Hmm interesting. I can't find any different behaviors either. The only things that I notice being different between the requests made in V2 vs. V3 are:

I don't know what it could be if none of these are the issues.