search

OpenConceptLab / ocl_issues

Issues for all OCL repos. NOTE: Install ZenHub Browser Extension and request access to the OCL Roadmap board to view all issues and to contribute
4 stars 1 forks source link

CIEL Content Feedback and Issues #622

Closed jamlung-ri closed 3 years ago

jamlung-ri commented 3 years ago

Andy will list out any bugs he finds while looking through CIEL content on AWS Staging.

askanter commented 3 years ago

On the mapping tab, the maps show the FROM source and not the TO source (i.e., they have CIEL with the SNOMED code listed)

askanter commented 3 years ago

When creating a custom tab, the customizations do not appear to show on the filters: { type: 'concepts', label: 'Problems', layout: 'List', default: false, filters: { concept_class: 'Diagnosis' }, page_size: 25 },

1) the List or Row parameter for layout doesn't apply. 2) how do I create a filter for two concept_classes together (OR)? 3) how do I set default sort (Name, alpha ascending)

askanter commented 3 years ago

When Changing sort to "Name" the default sort is descending Z->A . Default for name should be ascending.

askanter commented 3 years ago

When editing a CIEL concept in the browser, all names/descriptions do not have a type and therefore cannot be saved. The UI appears to default a null type to FULLY SPECIFIED, but that does not apply when saving an edited version. Correct behavior should be to convert null types to fully specified upon editing.

jamlung-ri commented 3 years ago 
1. the List or Row parameter for layout doesn't apply.

@askanter Is this still happening? I was looking at the CIEL Default config, and it seemed to reflect the JSON config file. The Problems tab and the Drugs tabs appear as List View. Maybe I am misunderstanding the issue, or maybe Sunny already got to this.

2. how do I create a filter for two concept_classes together (OR)?

To set a filter for concept_class = "123" or concept_class = "abc", you can use filters: { concept_class: '123,abc' },

(Note that there is NOT a space after the comma. A space will make the filter not work.)

3. how do I set default sort (Name, alpha ascending)

Default sort is being addressing in ticket #647

askanter commented 3 years ago

Awesome. The default view seems to work now. How do I set a config file to be the default for the source?

Andrew S. Kanter, MD MPH FACMI FAMIA

Asst. Prof. of Clinical Biomedical Informatics and Clinical Epidemiology Columbia University Email: @. / @. Mobile: +1 (646) 469-2421 Skype: akanter-ippnw Yahoo: andy_kanter 

On Tuesday, March 16, 2021, 6:56:32 AM CDT, Joseph Amlung ***@***.***> wrote:
  1. the List or Row parameter for layout doesn't apply.

@askanter Is this still happening? I was looking at the CIEL Default config, and it seemed to reflect the JSON config file. The Problems tab and the Drugs tabs appear as List View. Maybe I am misunderstanding the issue.

  1. how do I create a filter for two concept_classes together (OR)?

To set a filter for concept_class = "123" or concept_class = "abc", you can use filters: { concept_class: '123,abc' },

(Note that there is NOT a space after the comma. A space will make the filter not work.)

  1. how do I set default sort (Name, alpha ascending)

Default sort is being addressing in ticket #647

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

askanter commented 3 years ago

There is no way for me to create a new collection in the UI (permission issue)? If so, please fix. Same is true for adding mappings and concepts (from the appropriate screens. I can only add concepts and mappings from the source screen.

jamlung-ri commented 3 years ago

Awesome. The default view seems to work now. How do I set a config file to be the default for the source?

Under the Manage View Configurations screen, the Default button makes your view the default (see example image).

image

jamlung-ri commented 3 years ago

There is no way for me to create a new collection in the UI (permission issue)? If so, please fix. Same is true for adding mappings and concepts (from the appropriate screens. I can only add concepts and mappings from the source screen.

@askanter Since you're a member of CIEL, then you should be able to make concept, mappings, collections, etc. Just to make sure, you are not seeing these prompts on OCL?

On https://app.staging.aws.openconceptlab.org/#/orgs/CIEL : image

On https://app.staging.aws.openconceptlab.org/#/orgs/CIEL/sources/CIEL/ : image

askanter commented 3 years ago

Yes, but I would want to be able to add a new collection when I have selected concepts like in the old UI. Add to Collection should provide a way to create and add at the same time. For mappings, they should be added at the concept level with the from concept pre-determined.

jamlung-ri commented 3 years ago

Yes, but I would want to be able to add a new collection when I have selected concepts like in the old UI. Add to Collection should provide a way to create and add at the same time. For mappings, they should be added at the concept level with the from concept pre-determined.

Oh, I understand now. I think that's on our radar but I'll make sure there's a ticket.

askanter commented 3 years ago

Also, when assigning a locale to a collection, there are multiple duplicates in the list (en, es, fr, etc.)

snyaggarwal commented 3 years ago

Fixed -- Multiple locales https://github.com/OpenConceptLab/ocl_issues/issues/622#issuecomment-800318005

Will be available in next Staging deployment

jamlung-ri commented 3 years ago

Yes, but I would want to be able to add a new collection when I have selected concepts like in the old UI. Add to Collection should provide a way to create and add at the same time. For mappings, they should be added at the concept level with the from concept pre-determined.

This was completed in #652 and should be deployed soon.

snyaggarwal commented 3 years ago

When Changing sort to "Name" the default sort is descending Z->A . Default for name should be ascending.

This is done

jamlung-ri commented 3 years ago

@askanter just FYI, default sort has been addressed in ticket #647

askanter commented 3 years ago
image

Not positive, but I think the locales are not meant to be sentence cased. ISO standard is lower case.

askanter commented 3 years ago

Not sure what is happening here with the display of the first few lines of mappings in CIEL:

image
askanter commented 3 years ago

Please add askanter to the CIEL organization so that I can test editing capabilities.

askanter commented 3 years ago

Low priority but on editing a mapping, the preferred concept name does not appear on this screen (lower right corner):

image
askanter commented 3 years ago

Duplicate sources appearing in edit mapping:

image
askanter commented 3 years ago

BTW--a possible suggestion, when editing a mapping, the mapping type is not the first thing you should see. It seems that what you care about is the TO CONCEPT and the mapping type (in that order). The FROM CONCEPT should be obvious, but if we are going to be able to see the full information, the easiest way to edit this is just use the same layout as displayed but allow for changing the data (drop down for mapping type, replace button for the TO CONCEPT, etc.

jamlung-ri commented 3 years ago

Please add askanter to the CIEL organization so that I can test editing capabilities.

@askanter I just added you to https://app.staging.aws.openconceptlab.org/#/orgs/CIEL/

askanter commented 3 years ago

Search results are inexplicable. See below search for "breast malignant" image

jamlung-ri commented 3 years ago

Closing this out for now since we have addressed this, but feel free to create a new ticket or reopen this ticket if more issues arise. We will be documenting other CIEL needs here: https://docs.google.com/document/d/1kwC-AOi_tkzWGw33G5ieLz9i6wSimh8RzXzCl-NRg_M/edit#