Name_type Standardization

[jamlung-ri]

Standardize the format of the name_type attribute in OCL.

For example, we are seeing name_type attributes that are "Fully Specified" (link) and name_type attributes that are "FULLY_SPECIFIED" (link).

Note that OpenMRS Dictionary Manager will be slightly affected by it, so we should coordinate with that team when we start to implement these changes.

[jamlung-ri]

@snyaggarwal I believe the OpenMRS team is primarily using Staging and Prod environments, so we'll want to communicate with them before this change gets pushed to those envs. Are you wanting to push this out ASAP, or will it wait a little before we push this change to them?

[jamlung-ri]

Also, does this change only affect existing names, or will it affect new concepts too? If there's anything that the OpenMRS team will need to change themselves, I want to make sure they're aware.

[snyaggarwal]

@jamlung-ri it affects existing and new concepts and it only affects the display of the name_type -- No need to change the import script or any type of input. The code should be able to standardize from the input given. Also, I am done with these changes and it's on a separate branch (pull request). Will ask for a review and second opinion (may be showcase) before merging and promoting this to any env.

[paynejd]

@paynejd to verify how this will impact existing integration scripts and we will discuss again on our next architecture call

[bmamlin]

We discussed on the 2021-08-13 architecture call and I suggested we start by standardizing any code that's importing or creating imports to use the standard name types and then enforce those standard name types in the custom validation schema.

For the record, the three standard OpenMRS Concept Name Types are all capitals with underscores:

• "FULLY_SPECIFIED"
• "SHORT"
• "INDEX_TERM"

[jamlung-ri]

Moving to next sprint. We are also working on this in the OCL Architecture notes.

[lnball]

This thread/ticket is from 2 years ago and not new news for the team.

I just added a Spanish name (Capsula) to an existing concept (Capsule) in OCL. It appears as "Fully-Specified" instead of (UPPER CASE) "FULLYSPECIFIED"? Also it has a '-' (dash) instead of '' (underscore). We should be consistent and it shouldn't be a problem with the export into OpenMRS.

[paynejd]

Note that name types are also presented differently in the filters panel than they are actually stored. For example, FULLY SPECIFIED in the filters panel is actually FULLY_SPECIFIED (with an underscore). This inconsistency can be confusing.