OpenConext / Monitor-bundle

Openconext bundle for monitoring endpoints
Apache License 2.0
5 stars 2 forks source link

Allow reading of version information from env-vars #11

Closed MKodde closed 2 months ago

MKodde commented 5 months ago

At this point, you can set three env-vars that are evaluated to display on the /info endpoint.

If these variables are not present, the default behavior triggers (determining the version info based on the path information.

  1. By default this is docker friendly (as our OpenContext images ship with these env-vars)
  2. The fallback is usefull for when you install the application on bare metal, and unzip our openconext tarbals.
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 45.90164% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 42.70%. Comparing base (5aab82c) to head (9fad7f1). Report is 5 commits behind head on main.

:exclamation: Current head 9fad7f1 differs from pull request most recent head 56af0ca. Consider uploading reports for the commit 56af0ca to get more accurate results

Files Patch % Lines
src/Value/BuildEnvVars.php 53.84% 12 Missing :warning:
src/Value/BuildPath.php 33.33% 8 Missing :warning:
src/Controller/InfoController.php 0.00% 7 Missing :warning:
src/Value/Information.php 0.00% 3 Missing :warning:
src/Controller/HealthController.php 0.00% 1 Missing :warning:
...c/DependencyInjection/Compiler/HealthCheckPass.php 0.00% 1 Missing :warning:
...DependencyInjection/OpenConextMonitorExtension.php 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11 +/- ## ============================================ + Coverage 41.17% 42.70% +1.53% - Complexity 52 71 +19 ============================================ Files 12 15 +3 Lines 153 192 +39 ============================================ + Hits 63 82 +19 - Misses 90 110 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.