search

OpenConext / Monitor-bundle

Openconext bundle for monitoring endpoints
Apache License 2.0
5 stars 2 forks source link

Symplify autowiring and remove backticks #19

Closed parijke closed 4 months ago

parijke commented 4 months ago

fixes #15

Advantages: really simple services.yml. If you want to override the autowiring defaults, you could define an entry in the services.yaml.

How it works: All services which implements HealthCheckInterface are tagged with openconext.monitor.health_check, that is why is is not needed in the Extension anymore. The TaggableIterator is initialized with al services tagged like this. That is why the CompilerPass becomes obsolete.

Just as flexible as before, just much simpeler. Thanks Symfony! Also see: https://symfony.com/doc/current/bundles/extension.html

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 45.08%. Comparing base (62f51d5) to head (642f803). Report is 9 commits behind head on main.

:exclamation: Current head 642f803 differs from pull request most recent head e83bde5

Please upload reports for the commit e83bde5 to get more accurate results.

Files Patch % Lines
src/HealthCheck/DoctrineConnectionHealthCheck.php 0.00% 6 Missing :warning:
src/Controller/InfoController.php 0.00% 2 Missing :warning:
src/OpenConextMonitorBundle.php 0.00% 2 Missing :warning:
src/Controller/HealthController.php 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ============================================ + Coverage 41.17% 45.08% +3.91% - Complexity 52 65 +13 ============================================ Files 12 13 +1 Lines 153 173 +20 ============================================ + Hits 63 78 +15 - Misses 90 95 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MKodde commented 4 months ago

@tacman does this solve your issues as proposed in #15? The other suggestion to allow for setting a custom query is still in our pipeline. We recently ran into an issue where checking existence of a certain table was very useful.