search

OpenConext / Mujina

A mock IDP and SP using the OpenSAML library
Apache License 2.0
369 stars 166 forks source link

[RP-88921] Copy dependency JARs to target dir and use fixed name for service JAR #63

Closed cliebBS closed 4 years ago

cliebBS commented 4 years ago

Help improve the startup time of the Mujina Docker image by baking all JARs into image. To help with this, copy all dependency JARs into a fixed location (mujina-idp/target/dependencies and mujina-sp/target/dependencies) so that we don't need Maven in the runnable image. Additionally, use a fixed (versionless) name for the built JARs for the Mujina IDP and SP.

codecov[bot] commented 4 years ago

Codecov Report

Merging #63 into master will decrease coverage by 2.54%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     93.83%   91.28%   -2.55%     
- Complexity      130      155      +25     
============================================
  Files            24       29       +5     
  Lines           454      551      +97     
  Branches          5       11       +6     
============================================
+ Hits            426      503      +77     
- Misses           25       37      +12     
- Partials          3       11       +8
Impacted Files Coverage Δ Complexity Δ
...a-idp/src/main/java/mujina/idp/UserController.java 75.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
...na-idp/src/main/java/mujina/idp/SsoController.java 72.72% <0.00%> (-22.52%) 10.00% <0.00%> (+3.00%) :arrow_down:
...c/main/java/mujina/idp/AuthenticationProvider.java 88.88% <0.00%> (-11.12%) 9.00% <0.00%> (ø%)
mujina-idp/src/main/java/mujina/api/User.java 100.00% <0.00%> (ø) 6.00% <0.00%> (+1.00%)
mujina-sp/src/main/java/mujina/sp/SAMLConfig.java 94.11% <0.00%> (ø) 17.00% <0.00%> (ø%)
...ina-sp/src/main/java/mujina/sp/UserController.java 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
...na-idp/src/main/java/mujina/api/IdpController.java 100.00% <0.00%> (ø) 12.00% <0.00%> (+4.00%)
...a-sp/src/main/java/mujina/api/SpConfiguration.java 75.86% <0.00%> (ø) 6.00% <0.00%> (ø%)
...idp/src/main/java/mujina/api/IdpConfiguration.java 90.24% <0.00%> (ø) 8.00% <0.00%> (ø%)
...p/src/main/java/mujina/idp/MetadataController.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2b63a7...5fd04bd. Read the comment docs.