search

OpenConext / Mujina

A mock IDP and SP using the OpenSAML library
Apache License 2.0
369 stars 166 forks source link

Make SAML binding configurable via idp.saml_binding #86

Closed mloesch closed 1 year ago

mloesch commented 1 year ago

Currently the SAML redirect binding is hardcoded in the IDP configuration. However, our SP only works with the HTTP POST binding.

This PR makes the binding type configurable via a property. I tested this with the HTTP POST binding (urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST) against our SAML SP and it works fine.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.25%. Comparing base (71528b3) to head (215b52f). Report is 23 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ========================================= Coverage 91.25% 91.25% Complexity 165 165 ========================================= Files 30 30 Lines 583 583 Branches 17 17 ========================================= Hits 532 532 Misses 37 37 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.