search

OpenConext / OpenConext-BaseContainers

Docker base images used by all OpenConext projects that use docker containers
Apache License 2.0
0 stars 1 forks source link

Merge entrypoints #18

Closed danakim closed 9 months ago

danakim commented 10 months ago

@quartje - my latest commit brings in all the changes we discussed today and in your comment above. Basically we have more standard entrypoint name and path and for Shibboleth we have an extra script, used in CMD.

quartje commented 10 months ago

This should work. I see that the entrypoint.sh scripts are not chmodded with an execute bit. Have you tested them that they work without explicit chmod?

danakim commented 10 months ago

@quartje - it should work! Tested it. But just to make sure, I added an explicit chmod +x in all Dockerfiles, check my latest commit.

danakim commented 10 months ago

@quartje fixed your latest request in the latest commit. Apache won't have write rights to the files / application directory. Only to the ones it needs: cache, logs and runtime (pid).

danakim commented 10 months ago

@quartje - to answer your latest requests:

  1. Right! No need to do that on the non-php images. I copied the script everywhere to keep it consistent, but it is not needed. Removed the cache command on the plain apache2 images.
  2. I added a check for the directory.
  3. I remember that that is the default bash behaviour: to continue on errors. But I think because we use it as an entrypoint on docker, it changes that behaviour as docker wants a clean run / exit. I have added the set command. But one note: set -e actually tells bash to exit immediately on any error. Basically the opposite of what you want. The command we want is set +e and I have added in the last commit.