OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Fatal error with blank page on invalid XML input #118

Closed relaxnow closed 8 years ago

relaxnow commented 9 years ago

Example: https://engine.surfconext.nl/authentication/idp/single-sign-on?SAMLRequest=f

relaxnow commented 9 years ago

Also gives the following PHP errors:

PHP Warning:  gzinflate(): data error in /opt/openconext/OpenConext-engineblock-4.2.10/vendor/simplesamlphp/saml2/src/SAML2/HTTPRedirect.php on line 111
PHP Warning:  DOMDocument::loadXML(): Empty string supplied as input in /opt/openconext/OpenConext-engineblock-4.2.10/vendor/simplesamlphp/saml2/src/SAML2/HTTPRedirect.php on line 120
PHP Catchable fatal error:  Argument 1 passed to SAML2_Message::fromXML() must be an instance of DOMElement, null given, called in /opt/openconext/OpenConext-engineblock-4.2.10/vendor/simplesamlphp/saml2/src/SAML2/HTTPRedirect.php on line 123 and defined in /opt/openconext/OpenConext-engineblock-4.2.10/vendor/simplesamlphp/saml2/src/SAML2/Message.php on line 506
thijskh commented 8 years ago

The "blank page" has been fixed in EB 4.7; it now generates "Error - An error occurred" when this happens.

thijskh commented 8 years ago

The library will also log a more concrete error when this happens. Case closed.