search

OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Bug: Remember Choice cookie has double quotes around the entityID #1326

Open ArnoutvdKnaap opened 2 months ago

ArnoutvdKnaap commented 2 months ago

Currently the rememberchoice cookie has a value of "<entityID>" instead of <entityID>. Due to this a match is never found in: https://github.com/OpenConext/OpenConext-engineblock/blob/2b198535f21652833095bc17cd3a2cc9a6769ebe/library/EngineBlock/Corto/Module/Service/SingleSignOn.php#L210 Where the extra "" come from are a currently a mistery to me.

ArnoutvdKnaap commented 2 months ago

I fix this by doing removing the "" on line 209 before saving $remebered. I could supply this 'fix' for the new version of EngineBlock but it seems like not saving the "" in the first place would be a better solution.