OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Handle error assertion from SFO endpoint #1572

Closed phavekes closed 3 days ago

phavekes commented 3 days ago

This issue is imported from pivotal - Originaly created at Jun 17, 2019 by Thijs Kinkhorst

When the authentication at SFO does not succeed, it will return a SAML assertion with a status code, a sub status code and optionally a status message.

Engine should handle this and stop authentication. Present an error screen to the user.

The screen should clearly indicate that the second factor verification failed and that this means we cannot continue. And what the reason was that second factor verfication was attempted (per sp configuration, per idp/sp configuration (might be more reasons in the future).

Handle specific status codes (see https://wiki.surfnet.nl/display/SsID/Second+Factor+Only+%28SFO%29+Authentication under Error Handling):

Display the received status codes and message if present.

Estimation: 8 - 12h

phavekes commented 3 days ago
@thijskh could you supply us with the final error messages? (bstrooband - Jul 10, 2019)
phavekes commented 3 days ago

For the error messages it would be useful to have a configurable variable for "SURFsecureID" just like we have %suiteName% now. E.g. "%stepupSuiteName%". If this is a lot of work then we\'ll think of another way to solve this.

Here are the messages.

user canceled

onvoldoende loa

other sfo error

phavekes commented 3 days ago

All errors should show in the extra information block the saml status message if one is given.

The last error should show all the following in the extra information blocks: saml status code, saml sub status code, saml status message (Thijs Kinkhorst - Jul 23, 2019)

phavekes commented 3 days ago
@thijskh thanks for the messages! (bstrooband - Jul 24, 2019)
phavekes commented 3 days ago

I haven\'ty implemented \'Display the received status codes and message if present.\' yet because of the changes in 5.11. This could be addressed better after the final error page layout changes are done. (bstrooband - Aug 9, 2019)

phavekes commented 3 days ago

Apologies, the texts for onvoldoende loa are slightly wrong.

Following correction requested:

phavekes commented 3 days ago

Need rework (bstrooband - Aug 20, 2019)

phavekes commented 3 days ago
The link does not work (in FF), because of an HTML error (missing `=` after `href`):
<a target="_blank" href"https://support.surfconext.nl/stepup-noauthncontext">

@bstrooband (Thijs Kinkhorst - Aug 23, 2019)

phavekes commented 3 days ago

The mentioned text changes (comment of Aug 20, 4:34 pm) have not been applied (Thijs Kinkhorst - Aug 27, 2019)

phavekes commented 3 days ago

While we are at it, please change the URL for NL to https://support.surfconext.nl/stepup-noauthncontext-nl (extra suffix -nl) (Thijs Kinkhorst - Aug 27, 2019)

phavekes commented 3 days ago

The changes were merged back to the wrong branch. This have been fixed. I directly applied the suggested suffix. (bstrooband - Aug 28, 2019)