OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Fix all missing copyright notices at once #1580

Closed phavekes closed 2 hours ago

phavekes commented 2 hours ago

This issue is imported from pivotal - Originaly created at Jul 19, 2019 by bstrooband

There are a couple of places where the copyright notices are missing from the code. To prevent keeping this from returning in reviews I think we should automate this task to prevent this unnecessary overhead.

Could we use the year of first publication (a fixed year) because then we could automate this task? I would suggest 2014.

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
phavekes commented 2 hours ago
@thijskh what do you think about this? (bstrooband - Jul 19, 2019)
phavekes commented 2 hours ago

Fine to add to all files with a fixed copyright year (Thijs Kinkhorst - Jul 19, 2019)

phavekes commented 2 hours ago

But what about new files? They should reflect the year they are created right? It feels really counter-intuitive to set them with a year from the past.

Also, what should be the copyright year for the files currently not \'tagged\' with a copyright? The first Github tag of EB (1.0.0) is from march 2011. But development might have started at an earlier point in time? (Michiel Kodde - Aug 22, 2019)

phavekes commented 2 hours ago

The year really does not bear any significance and files are part of the total product.

Fine with me to put "2010" everywhere (year of first commit). Or the year the notice was added to the file (so a notice added today lists 2019). But please no updating of years after that. It serves no purpose and pollutes the git history. (Thijs Kinkhorst - Aug 23, 2019)

phavekes commented 2 hours ago

Updated the year to 2010 (bstrooband - Aug 27, 2019)