OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Friendly error message when using non-existent entityID on idps-metadata #1593

Closed phavekes closed 3 hours ago

phavekes commented 3 hours ago

This issue is imported from pivotal - Originaly created at Sep 3, 2019 by Thijs Kinkhorst

https://github.com/OpenConext/OpenConext-engineblock/issues/211

EB should give an error along the lines of "entityID not found", "SP unknown"

phavekes commented 3 hours ago

Hi @thijskh, @bartgeesink, @pmeulen.

A first proposal for the error message displayed when the SP entity can not be found during metadata generation. Note that the original (English) exception message is rendered in the Dutch text.

  1. Is this okay?
  2. Is the chosen title & description OK? If not please suggest your preference.

English title: Metadata can not be generated English desc: The following error occurred: %message% English message (sp metadata not found): Unable to find the SP with entity ID "%s".

Dutch title: Metadata kan niet gegenereerd worden Dutch desc: De volgende fout is opgetreden: %message% Dutch message: The english message is rendered.

The Portuguese translations will be offloaded to Dominguez as soon as the English texts are finalized. (Michiel Kodde - Oct 1, 2019)

phavekes commented 3 hours ago

Yes, all fine. These messages are aimed at SP operators who arr expected to be able to understand an English exception message. (Thijs Kinkhorst - Oct 1, 2019)