OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Possible accessibility improvements for WAYF #1660

Closed phavekes closed 3 hours ago

phavekes commented 3 hours ago

This issue is imported from pivotal - Originaly created at Feb 18, 2020 by Michiel Kodde

When navigating the page with the tab key:
  1. The search bar receives focus early on. Good thing!
  2. Tabbing over the search bar should land you in the IdP list, where you should be able to select an IdP with the keyboard. This is not possible.

Running the Axe puppeteer plugin yielded several suggestions.

phavekes commented 3 hours ago

Maybe check if we\'ve coivered all this in the redesign @Koenekijn (Thijs Kinkhorst - Dec 11, 2020)

phavekes commented 3 hours ago
@thijskh Save for the last one they have all been solved with the new design.  We get a 100% accessible score on Axe now ^__^  

The last one doesn\'t make sense for engineblock, as there is no navigation to skip. There is only main content, both on the WAYF and the consent screen.

I should note that the error/form/index page have not been checked for accessibility as there was no design for that. None the less: both error & index page pass the axe plugin test now after solving the issues that came up. (Koen Cornelis - Dec 11, 2020)

phavekes commented 3 hours ago

Should we close this? (Koen Cornelis - Dec 11, 2020)

phavekes commented 3 hours ago
@Koenekijn Yes, we can close this. Excellent to have the error/index also accessible. (Thijs Kinkhorst - Dec 11, 2020)