OpenConext / OpenConext-engineblock

OpenConext SAML 2.0 IdP/SP Gateway
14 stars 22 forks source link

Questionable code in library/EngineBlock/View.php #335

Closed thijskh closed 7 years ago

thijskh commented 8 years ago

There's some code which raises questions in library/EngineBlock/View.php:

Here's a test but there's no assignment done: https://github.com/OpenConext/OpenConext-engineblock/blob/master/library/EngineBlock/View.php#L122

Code has been introduced in b7a44998355272a94f328d4281e0a5b5b719ad2c which suggests it's dead code now; other tests seem to confirm this. Should probably be removed.

thijskh commented 8 years ago

Would check out if this function where it's contained and related functions are not dead code anyway.

thijskh commented 7 years ago

Fixed in #397