search

OpenConext / OpenConext-myconext

A (guest) IdP for OpenConext
https://eduid.nl/
4 stars 7 forks source link

Clarify help text for maxAttempt #194

Closed thijskh closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f88f2cc) 89.53% compared to head (5c30b57) 89.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #194 +/- ## ========================================= Coverage 89.53% 89.53% Complexity 1024 1024 ========================================= Files 111 111 Lines 3441 3441 Branches 274 274 ========================================= Hits 3081 3081 Misses 249 249 Partials 111 111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phavekes commented 7 months ago

Max attempts means you've already gone back and tried several times

thijskh commented 7 months ago

No, I can trigger this by going to an SP, log in, and type the emailed code wrongly three times. And can then go back to the SP to restart an authnrequest and I get new attempts.

NOTE: this is not "Max attempts" but "maxAttempt".