OpenConext / OpenConext-myconext

A (guest) IdP for OpenConext
https://eduid.nl/
5 stars 8 forks source link

Opening email-change-link generated on mobile on desktop cause dead end #551

Open phavekes opened 2 months ago

phavekes commented 2 months ago

This issue is imported from pivotal

If I start changing my email address in the app, I\'ll receive an email to confirm. If the link is opened on the desktop, the user can\'t continue and the email is not changed

https://login.test.eduid.nl/client/mobile/update-email?h=D04euCOP92HXeTTz134PV8ssCWNtEFP4d-3gTiafJFjlcyg0p0rLBGbj1qynkW-VSf43kjbM27DQOg8F8zWUZA

phavekes commented 2 months ago

(Peter Havekes - Sep 18, 2023)

phavekes commented 2 months ago

We\'ve removed the eduid:// scheme from the app(s) for API access and oauth flow. These \'fallback buttons\' to eduid:// do not work anymore.

The fallback-buttons on the /client/mobile pages should point to mijn.eduid.nl (Peter Havekes - Sep 18, 2023)

phavekes commented 2 months ago

@phavekes The redirect to the mobile app is configurable. See https://github.com/OpenConext/OpenConext-deploy/blob/master/roles/myconext-server/templates/application.yml.j2#L68.

The generic redirect to the eduID app in the /client/mobile pages includes the query parameters and also the original action. The mobile app has all the information to finish the request. See also https://github.com/OpenConext/OpenConext-myconext/blob/master/account-gui/src/locale/en.js#L126 for all possible actions and the information to the user. If we correct the redirectURL in OpenConext-deploy then I think we should solve this in the app.

In the above example clicking the button triggers eduid:///client/mobile/update-email?h=D04euCOP92HXeTTz134PV8ssCWNtEFP4d-3gTiafJFjlcyg0p0rLBGbj1qynkW-VSf43kjbM27DQOg8F8zWUZA. The eduid:// scheme is configurable (Okke Harsta - Oct 11, 2023)

phavekes commented 2 months ago

2DO: Add option to poll from the app. This makes the app continue when the link was opened on web (Peter Havekes - Jun 17, 2024)