OpenConext / OpenConext-profile

Shows user's attributes and other profile information
Apache License 2.0
2 stars 0 forks source link

Clicking on accessed services will result in error if the consent feature in EB is disabled #255

Closed ArnoutvdKnaap closed 1 year ago

ArnoutvdKnaap commented 1 year ago

EB API will return a 404 when asked for consent if the feature is disabled. This will return a symfony error in profile

thijskh commented 1 year ago

This is correct. Profile uses the consent information to be able to show which service providers you logged into. What would you expect to happen?

ArnoutvdKnaap commented 1 year ago

I expected to see a blank page or not available instead of a symfony crash report

thijskh commented 1 year ago

This is what the user sees:

Onverwachte fout. Er ging iets mis. Probeer het opnieuw, of neem contact op met support als het probleem aanhoudt

This is currently logged: OpenConext\EngineBlockApiClientBundle\Exception\ResourceNotFoundException: "Resource "consent/urn%3Acollab%3Aperson%3Aexample.com%3Aadmin" not found"

I can add to that exception message something like "Is Engineblocks consent feature enabled?"

Logging should suffice I think - I don't think it's worthwhile to add a specific end user facing message in this case since it's only the admin that can resolve this?

ArnoutvdKnaap commented 1 year ago

Am I doing something wrong than? Because i get this message:

thijskh commented 1 year ago

It's the same message but you're running the application in development mode.

ArnoutvdKnaap commented 1 year ago

Ah i see. That is a lot better yes. :D