OpenConext / OpenConext-user-lifecycle

Deprovision users within the OpenConext platform
Apache License 2.0
1 stars 0 forks source link

Migrate TravisCI to Github Actions for test-integration #50

Closed VadimSchmitz closed 2 years ago

VadimSchmitz commented 2 years ago

TravisCI and Ant scripts have been fully replaced with GHActions and Composer scripts. However the tests will currently not pass due to deprecation warnings given by PHPUnit. these could be omitted, (see SYMFONY_DEPRECATIONS_HELPER) in https://github.com/OpenConext/Stepup-RA/blob/develop/ci/qa/phpunit.xml

https://www.pivotaltracker.com/n/projects/2170047/stories/181279813

MKodde commented 2 years ago

After closer inspection of the GithubActions output I noticed this error in the PHPUnit output:

Error: This version of PHPUnit does not support code coverage on PHP 8

Could this be the cause of the 1 exit code? Deprecation warnings should not end in a non zero status IMHO.

MKodde commented 2 years ago

Your change looks good. Can you rebase onto develop before merging?