search

OpenConext / Stepup-AzureMFA

GSSP IdP for Stepup Authentication using Azure MFA
Apache License 2.0
0 stars 1 forks source link

Maintenance: Security updates #102

Closed MKodde closed 1 year ago

MKodde commented 1 year ago
  1. Yarn & Composer updates installed
  2. Upgraded Webpack Encore from v1 to 4
MKodde commented 1 year ago

The security updates are now breaking the unit and accpetance tests

I've investigated on my dev env and the following things are in the way:

  1. Chrome and or Chromedriver is not installed correctly. Ive fixed this on my dev machine. But it takes some more effort to land those changes in this project. And should not be part of this PR
  2. Behat tests fail on Symfony errors that the ErrorController is fishing services directly from the container using $this->get. That should be fixed in the stepup-bundle. Also not for this PR.

I feel OK to move forward with this, and tag it pre-release for now. We are about to overhaul this project and upgrade it to SF 5/6. So putting in this work now seems illogical.