search

OpenConext / Stepup-Deploy

Ansible deploy scripts for the Stepup project. Also: have a look in the wiki!
https://github.com/OpenConext/Stepup-Deploy/wiki
5 stars 10 forks source link

Add PHP Zip extension #121

Closed mroest closed 3 years ago

mroest commented 3 years ago

Webdriver requires zip extension. This will install the php zip extension RPM.

mroest commented 3 years ago

If the removed section was only ran for development builds, then this changes is OK with me. Was not fully sure thats the case. Can you confirm that?

Good question. @pmeulen, i believe you mentioned on slack to remove it when the extension was installed. Assuming the zip extension is available on test/prod/other anyway and therefor its safe to remove? Can you confirm?

pmeulen commented 3 years ago

If the removed section was only ran for development builds, then this changes is OK with me. Was not fully sure thats the case. Can you confirm that?

Good question. @pmeulen, i believe you mentioned on slack to remove it when the extension was installed. Assuming the zip extension is available on test/prod/other anyway and therefor its safe to remove? Can you confirm?

Yes, you can remove the "Stepup-Azure-MFA ext-zip requirement fix" task from Ansible deploy role. The block that the task is part of is only ran when installing from source.