OpenConext / Stepup-Project

Managing issues for Stepup-* projects
0 stars 0 forks source link

Improve styling of WAYG token selection screen #220

Closed phavekes closed 4 days ago

phavekes commented 4 days ago

This issue is imported from pivotal - Originaly created at Nov 16, 2017 by Michiel Kodde

Story: #144697285 introduced a token selection screen for identities with multiple suitable second factor tokens. This screen is a basic design now, an might benefit for some UI review.

Screenshot of the WAYG (where are you going) screen can be found in the comment section below.

phavekes commented 4 days ago

(Michiel Kodde - Nov 16, 2017)

phavekes commented 4 days ago

I\'ve created a screen for the WAYG screen, see attached. (Peter Clijsters - Mar 6, 2018)

phavekes commented 4 days ago

The changes for this feature can be found in this PR (Michiel Kodde - Mar 19, 2018)

phavekes commented 4 days ago

XS viewport screenshot

Input is welcome. (Michiel Kodde - Mar 20, 2018)

phavekes commented 4 days ago

Edited xs viewport (buttons are now aligned according to the design)

(Michiel Kodde - Mar 20, 2018)

phavekes commented 4 days ago

Michiel told me that this is the smallest possible screen, so this layout is fine. BTW: the OpenConext logo looks a bit small here, smaller then I think the SURFsecureID logo will be. Is this a potential problem? (Peter Clijsters - Mar 20, 2018)

phavekes commented 4 days ago

Smallest and normal size WAYG screens. Looks good. OK @peterclijsters1 ? (Pieter van der Meulen - Apr 18, 2018)

phavekes commented 4 days ago

It seems to me that the smallest screen does not fit on a "regular" mobile phone. How wide is the smallest screen? (Peter Clijsters - Apr 19, 2018)

phavekes commented 4 days ago

Tried it myself and my screen is smaller then the one @pmeulen showed. (Peter Clijsters - Apr 19, 2018)

phavekes commented 4 days ago
@peterclijsters1 WAYG in iPhone 7 simulator. It\'s not great, but usable IMO (Pieter van der Meulen - Apr 19, 2018)
phavekes commented 4 days ago

Agree, this is OK (Peter Clijsters - Apr 19, 2018)

phavekes commented 4 days ago
@peterclijsters1 OK, then push the green button :) (Pieter van der Meulen - Apr 19, 2018)
phavekes commented 4 days ago
Not yet.. If I select language NL in SA and press "Test een token", then the WAYG screen is English.. The tiqr and SMS screen after the WAYG are in NL again.

@michielkodde The WAYG screen should show the same language as selected in SA. (Peter Clijsters - Apr 19, 2018)

phavekes commented 4 days ago

I\'d have to look into this in more detail. Should be an easy fix. Can we fix this in a bugfix ticket instead of adding it to this feature? #156947307 (Michiel Kodde - Apr 20, 2018)

phavekes commented 4 days ago

Rejected. Please have a look at:

phavekes commented 4 days ago
@peterclijsters1 Point 1 and 3 have been fixed in this [PR](https://github.com/OpenConext/Stepup-Gateway/pull/159) (Michiel Kodde - May 3, 2018)
phavekes commented 4 days ago

Tested OK. BTW; I\'m not seeing the jump (point 2 in comment above) any more. (Peter Clijsters - May 24, 2018)