search

OpenConext / Stepup-RA

Stepup Registration Authority
Apache License 2.0
2 stars 2 forks source link

Change role on RA-management page #376

Closed phavekes closed 4 days ago

phavekes commented 4 days ago

This issue is imported from pivotal - Originaly created at Nov 1, 2018 by Michiel Kodde

Background In story #160283516 we lost the ability to change the role of a RA(A) user.

The story states:

Removed the Change Role buttons. It would be more complicated (allow changing of the institution too?), and it\'s not used that much in our options. Changing a role can be done by removing the role, and then adding the role again.

This change was applied in this commit: https://github.com/OpenConext/Stepup-RA/commit/acd1f8d86b1e7340978e594a1a541596e426fa84

Discussion: Why remove this button? The added complexity that is mentioned could be contained by only change the role within the context of the institution the RA(A) is RA at.

More background The Middleware received new events to handle these actions in a FGA manner. This code can be used. Or should be cleaned up if we decide not to use this feature!

phavekes commented 4 days ago 
@pmeulen what\'s your opinion on this? (Michiel Kodde - Nov 1, 2018)
phavekes commented 4 days ago

We don\'t want the feature, so please remove it.

My intention was to save implementation work and code complexity by stripping a little used feature of in our option little value to the user. The removal of the modify/change role button also reduces complexity in the user interface. (Pieter van der Meulen - Feb 7, 2019)

phavekes commented 4 days ago

Thanks for your feedback, it seemed like a regression to me. But if this option is little used than we can get away with this. In my opinion the complexity would not increase much as long as this change screen sticks to updating the role within the organisation the user is now RA(A). (Michiel Kodde - Feb 7, 2019)

phavekes commented 4 days ago

We judged that only updating the role (i.e RA<->RAA) and not allowing the "@" part (i.e. the institution) to be modified would be confusing. (Pieter van der Meulen - Feb 7, 2019)