search

OpenConext / Stepup-saml-bundle

A PHP Symfony bundle that adds SAML capabilities to your application using simplesamlphp/saml2
Apache License 2.0
14 stars 24 forks source link

getMainRequest not compatible with SF 4.4.37 #106

Closed epidoux closed 2 years ago

epidoux commented 2 years ago

Hi,

Thanks for this bundle!

It seems there is an issue on https://github.com/OpenConext/Stepup-saml-bundle/blob/690d1ba2aeeef536f26e5c599375d6d4b1d49007/src/Entity/HostedEntities.php#L145

getMainRequest() is not a valid method for SF4.4 (https://github.com/symfony/symfony/blob/v4.4.37/src/Symfony/Component/HttpFoundation/RequestStack.php) I guess it should be better to protect the call with method_exists and calling getMasterRequest() otherwise, no?

Didn't have time right now to check if there is other parts concerned but I can help if needed.

Thanks!