search

OpenConext / Stepup-saml-bundle

A PHP Symfony bundle that adds SAML capabilities to your application using simplesamlphp/saml2
Apache License 2.0
14 stars 24 forks source link

Make sure no null value is in ignoreUnkownAttributes #126

Closed parijke closed 4 months ago

parijke commented 5 months ago

In addition to set the correct parameters in Profile, this add some extra safety to make sure the value is never null

parijke commented 5 months ago

@MKodde @thijskh

What I noticed was that, although there is a default configuration, it is never used. You can test that by adding this in the load method of the extension:

$configuration = new Configuration();
$processedConfig = $this->processConfiguration($configuration, $configs);
dd($processedConfig, $configs);

You can see that in the $processedConfig variable, the defaults are there, and not in $configs. That is probably why the value wasn't set to false, because the definition is only set as the key exists, en left to null if not (the service.tml overruled the default vanlue in the service itself)

I am not sure if this is delibarate, or a bug?

See also https://www.pivotaltracker.com/story/show/187671164