Throw specific exceptions on signature errors - Githubissues

OpenConext / Stepup-saml-bundle

A PHP Symfony bundle that adds SAML capabilities to your application using simplesamlphp/saml2

Apache License 2.0

14 stars 24 forks source link

Throw specific exceptions on signature errors #78

Closed jorissteyn closed 6 years ago

jorissteyn commented 6 years ago

Instead of throwing bad request HTTP exceptions, new exceptions have been added for the following cases:

no signature found in request or no sigalg specified: -> UnsignedRequestException
the request was signed with an unsupported algorithm (not SHA_RSA256) -> UnsupportedSignatureException
validation of the signature failed -> SignatureValidationFailedException

All exceptions extend BadRequestHttpException so this change should be backwards compatible.