search

OpenConext / Stepup-saml-bundle

A PHP Symfony bundle that adds SAML capabilities to your application using simplesamlphp/saml2
Apache License 2.0
14 stars 24 forks source link

Allow retrieval of Scoping -> RequesterIds #97

Closed MKodde closed 4 years ago

MKodde commented 4 years ago

The requester ids can already be set as part of the setscoping method. Now they can also be retrieved.

This feature is created to aid: https://github.com/OpenConext/Stepup-gssp-bundle/pull/33 https://github.com/OpenConext/Stepup-Azure-MFA/pull/24

MKodde commented 4 years ago

Testing this change is very costly. It would entail creating faked request objects with a SAML authnrequest embedded. I'm with you on the importance of providing test coverage but this time its not economical I'm afraid.