search

OpenConext / Stepup-tiqr

tiqr IdP for step-up authentication
Apache License 2.0
3 stars 2 forks source link

Fixed reading the QR code as text in the AuthenticationCommand on dev environments #205

Closed mharte-ib closed 1 week ago

mharte-ib commented 2 weeks ago

The Authentication command wasn't able to read the QR code as text because it would try to convert to a string twice. Also added PHPStan for all dev code and improved some other reported problems, improving code quality.

MKodde commented 2 weeks ago

Thanks for these improvements and the actual bugfix!

You certainly earned your boyscout badge today :1st_place_medal:

Some small suggestions to make the commit messages more consistent with the ones currently in the git-log I personally try to follow the so called 'golden rules' for a good commit message:

https://dev.to/mitchiemt11/crafting-commits-with-finesse-the-7-rules-for-exceptional-git-commit-messages-2d8b You could set a commit message template to help you stick to those rules. I believe our (Ibuilidngs) 'lessons learned' Gitlab repository contains a template for this.

Edit: did not find the template in our Gitlab; but have a look at this article instead. This is what most of use use for the commit.template

https://codeinthehole.com/tips/a-useful-template-for-commit-messages/

mharte-ib commented 1 week ago

Thanks for these improvements and the actual bugfix!

You certainly earned your boyscout badge today 🥇

Some small suggestions to make the commit messages more consistent with the ones currently in the git-log I personally try to follow the so called 'golden rules' for a good commit message:

https://dev.to/mitchiemt11/crafting-commits-with-finesse-the-7-rules-for-exceptional-git-commit-messages-2d8b You could set a commit message template to help you stick to those rules. I believe our (Ibuilidngs) 'lessons learned' Gitlab repository contains a template for this.

Edit: did not find the template in our Gitlab; but have a look at this article instead. This is what most of use use for the commit.template

https://codeinthehole.com/tips/a-useful-template-for-commit-messages/

I've updated the commit messages, making them more explanatory.