search

OpenConext / Stepup-tiqr

tiqr IdP for step-up authentication
Apache License 2.0
3 stars 2 forks source link

Fix tiqr authentication status #66

Closed pablothedude closed 5 years ago

pablothedude commented 5 years ago

The status of the Tiqr authentication was not returned after it was successful because it would return an expired status as the check depended on a Memcache value which was cleared after success so the status returned an expired state. The logic order was changed so first, we check for successful authentication and after that we check if it's expired.

pablothedude commented 5 years ago

https://www.pivotaltracker.com/story/show/161717575

MKodde commented 5 years ago

The builds are failing on the security checker. Opening a new PR for this.

MKodde commented 5 years ago

@pablothedude, Your changes seem to make sense. Have not personally tested it functionally did you do this? Otherwise, I'll spin up my test environment.

I've opened #67, you might want to rebase your PR on that branch, or onto develop once it is merged.