search

OpenConext / Stepup-tiqr

tiqr IdP for step-up authentication
Apache License 2.0
3 stars 2 forks source link

Restore js (security) tests #98

Closed mroest closed 3 years ago

mroest commented 3 years ago

The current travis build did not work since yarn tests/checks are not running. This updates the js/css depencencies and restores the travis build.

mroest commented 3 years ago

Nice work again @mroest! This PR seems like a classic case of rabbit hole. Maybe next time try to bundle your work more atomically in several commits. I'm fine with these kind of PR's but I'd like the git history to be a bit more fine grained than this.

Yes, agreed. It turned out in to something bigger than expected. Although all the changes is just to get the travis build working it maybe would have been better to al least have it in a couple of different commits.