search

OpenConextApps / simplesamlphp-module-stepupsfo

OpenConext Stepup Second Factor Only Authproc Filter for SimpleSAMLphp :key:
GNU Lesser General Public License v2.1
4 stars 3 forks source link

Fixes for SSP 1.19 #1

Closed tvdijen closed 2 years ago

tvdijen commented 2 years ago

SSP 1.19 dropped support from array-style NameIDs. Use setters instead

tvdijen commented 2 years ago

Please merge & tag a release, and then branch of so we can work on SSP 2.0 compatibility in master

dnmvisser commented 2 years ago

i can confirm this fixes the Call to undefined method SAML2\XML\saml\NameID::fromArray() and Cannot access protected property SAML2\XML\saml\NameID::$value errors that I saw in my SimpleSAMLphp 1.19.5 logs

tvdijen commented 2 years ago

Those were introduced in SSP 1.19 where we dropped the use of array-style NameIDs, so it makes full sense

dnmvisser commented 2 years ago

can this be tagged..? or whatever is needed to make a tarball available at https://github.com/OpenConextApps/simplesamlphp-module-stepupsfo/archive/refs/heads/vxxxx.zip

thijskh commented 2 years ago

https://github.com/OpenConextApps/simplesamlphp-module-stepupsfo/archive/refs/heads/main.zip

dnmvisser commented 2 years ago

yes ok thanks but already used that URL, but i was looking for something more stable, as this will be a different tarball on each next commit.

thijskh commented 2 years ago

https://github.com/OpenConextApps/simplesamlphp-module-stepupsfo/releases/tag/v1.0.0