search

OpenCosmics / cosmic-jupyter

1 stars 4 forks source link

QuarkNet DAQ decoding #5

Closed tpmccauley closed 8 years ago

tpmccauley commented 8 years ago

A few classes and some code to read in the QN data format and to decode into objects

RaoOfPhysics commented 8 years ago

@Tontonis, @twhyntie: Would one of you gents be so kind as to check @tpmccauley's code and merge the PR if all looks good? Thank you. :)

twhyntie commented 8 years ago

Are we going to insist on not committing to master yet? :wink:

https://guides.github.com/introduction/flow/

RaoOfPhysics commented 8 years ago

No harm in merging a PR into master, but ideally you'd work on a named branch (preferably indicating the problem or solution). :) @tpmccauley's going to have to deal with conflicts when he tries to git pull upstream master. :D

tpmccauley commented 8 years ago

Code should make it to the master eventually anyway; as long as I am adding a new notebook and not working on code others may be working on then no problem I think to push from my master.

twhyntie commented 8 years ago

LGTM - enjoying the Panda stuff :smile:

@Tontonis?

RaoOfPhysics commented 8 years ago

@twhyntie: If one of you has vetted the PR, I think it's fine to merge. I tagged both in case one was busy. :)

tpmccauley commented 8 years ago

Thanks all. Now is the last of my pushes to master :)