OpenCosmics / fits-evaluation

We will use hisparc's existing data to evaluate NASA's FITS format as an option for a generic open cosmic data format.
Apache License 2.0
6 stars 4 forks source link

Parse event data as CSV, and build a Python dict #8

Closed onyb closed 9 years ago

onyb commented 9 years ago

Improves upon pull request #5 by @Tontonis.

Tontonis commented 9 years ago

Much neater than my attempt, cool!

Tontonis commented 9 years ago

Pull request merged.

RaoOfPhysics commented 9 years ago

@Tontonis: OT, but thought you should know I'm in the Vidyo room we usually use.

kinow commented 9 years ago

Tested locally, working fine. Code looking good too :smile: as we are just experimenting I think it's fine to skip tests for now, but with a good code like this we can soon start writing tests if we settle down for a format.

onyb commented 9 years ago

@kinow: We can manage with some simple asserts for now. We might need better tests once we have a detailed specification for the format. In case you haven't seen, Frank has put up a rough map of the data structure on Gitter.